Skip to content

Expose Priority #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jun 5, 2025
Merged

Expose Priority #607

merged 14 commits into from
Jun 5, 2025

Conversation

roxblnfk
Copy link
Collaborator

@roxblnfk roxblnfk commented May 5, 2025 •
edited
Loading

What was changed

New API:

// New Priority DTO
$priority = Priority::new(priorityKey: 1);

// Set
WorkflowOptions::new()->withPriority($priority);
ChildWorkflowOptions::new()->withPriority($priority);
ActivityOptions::new()->withPriority($priority);

// Get
$priority = Activity::getInfo()->priority;
$priority = Workflow::getInfo()->priority;

Checklist

  1. Closes [Feature Request] Support Priority Annotations #559
  2. Wait
  3. How was this tested:
    • Manually
    • Added autotests
  4. Any docs updates needed?

Documentation

@vercel Vercel
Copy link

vercel bot commented May 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
php ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2025 6:35pm

@roxblnfk roxblnfk mentioned this pull request May 5, 2025
Closed
1 task
@roxblnfk roxblnfk requested a review from Sushisource June 5, 2025 10:55
@roxblnfk roxblnfk marked this pull request as ready for review June 5, 2025 10:55
@roxblnfk roxblnfk requested a review from wolfy-j as a code owner June 5, 2025 10:55
Sushisource
Sushisource approved these changes Jun 5, 2025
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@roxblnfk roxblnfk merged commit 210746d into master Jun 5, 2025
50 of 115 checks passed
@roxblnfk roxblnfk deleted the priority branch June 5, 2025 19:09
@roxblnfk roxblnfk added this to the 2.15.0 milestone Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

@wolfy-j wolfy-j Awaiting requested review from wolfy-j wolfy-j is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.15.0
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support Priority Annotations
2 participants
@roxblnfk @Sushisource